Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

[Jacek Anaszewski]

Hi Pavel,

Thanks for the review.

On 11/29/2014 08:26 PM, Pavel Machek wrote:
> Hi!
>
> > diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> > index 01e9f30..50a8dad 100644
> > --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> > +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> > @@ -41,6 +41,62 @@ Optional properties:
> >   	 To get more informations, please refer to documentaion.
> >   	[*] refer Documentation/devicetree/bindings/pwm/pwm.txt
> >
> > +- led-flash : the LED submodule device node
> > +
> > +There are two led outputs available - fled1 and fled2. Each of them can
> > +control a separate led or they can be connected together to double
> > +the maximum current for a single connected led. One led is represented
> > +by one child node.
> > +
> > +Required properties:
> > +- compatible : must be "maxim,max77693-flash"
> > +
> > +Optional properties:
> > +- maxim,fleds : array of current outputs in order: fled1, fled2
> > +	Note: both current outputs can be connected to a single led
> > +	Possible values:
> > +		0 - the output is left disconnected,
> > +		1 - a diode is connected to the output.
>
> Is this one needed? Just ommit child note if it is not there.

It is needed because you can have one led connected two both
outputs. This allows to describe such a design.

> > +- maxim,trigger-type : Array of trigger types in order: flash, torch
> > +	Possible trigger types:
> > +		0 - Rising edge of the signal triggers the flash/torch,
> > +		1 - Signal level controls duration of the flash/torch.
> > +- maxim,trigger : Array of flags indicating which trigger can activate given led
> > +	in order: fled1, fled2
> > +	Possible flag values (can be combined):
> > +		1 - FLASH pin of the chip,
> > +		2 - TORCH pin of the chip,
> > +		4 - software via I2C command.
>
> Is it good idea to have bitfields like this?
>
> Make these required properties of the subnode?

This is related to a single property: trigger. I think that splitting
it to three properties would make unnecessary noise in the
binding.

Best Regards,
Jacek Anaszewski

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/