Re: [PATCH] gpio-tz1090: fix error handling of irq_of_parse_and_map

From: Dmitry Torokhov
Date: Fri Nov 14 2014 - 19:44:13 EST


On Friday, November 14, 2014 11:53:07 PM James Hogan wrote:
> On Fri, Nov 14, 2014 at 01:32:56PM -0800, Dmitry Torokhov wrote:
> > irq_of_parse_and_map() returns 0 on error, so testing for negative
> > result never works.
> >
> > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxxxxxxx>
>
> Good catch, thanks!
>
> Acked-by: James Hogan <james.hogan@xxxxxxxxxx>
>
> A quick coccinelle script shows up numerous other cases of this error
> around the kernel tree too...

Yeah, I sent out a few patches today.

Thanks,
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/