Re: [RFC][PATCH 13/23 v4] tracing: Create seq_buf layer in trace_seq

[Steven Rostedt]

On Fri, 14 Nov 2014 17:26:52 +0100
Petr Mladek <pmladek@xxxxxxx> wrote:

> The return is redundant.
> 
> The above mentioned potential overflows happen only if
> we apply "[RFC][PATCH 17/23 v4]
> tracing: Have seq_buf use full buffer". The code is safe
> at this stage. The other problems are minor.
> 
> If you decide to address the potential overflows in another
> patch, feel free to add to this one:
> 
> Reviewed-by: Petr Mladek <pmladek@xxxxxxx>

Thanks.

I removed the redundant returns and the unused ret variable. I left the
dangerous copies in as I plan on addressing that after I introduce
seq_buf_used().

-- Steve

Here's the new patch: