Re: [PATCH 06/16] assoc_array: Replace smp_read_barrier_depends() with lockless_dereference()

[David Howells]

Pranith Kumar <bobby.prani@xxxxxxxxx> wrote:

>  static inline bool assoc_array_ptr_is_meta(const struct assoc_array_ptr *x)
>  {
> -	return (unsigned long)x & ASSOC_ARRAY_PTR_TYPE_MASK;
> +	return (unsigned long)lockless_dereference(x) &
> +						ASSOC_ARRAY_PTR_TYPE_MASK;
>  }

Nack.  x is not being dereferenced here, nor in some of the other places
you've added this.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/