Re: [PATCH] mm/zswap: add __init to some functions in zswap

[Ganesh Mahendran]

2014-11-13 10:55 GMT+08:00 Seth Jennings <sjennings@xxxxxxxxxxxxxx>:
> On Sun, Nov 09, 2014 at 08:23:52PM +0800, Mahendran Ganesh wrote:
>> zswap_cpu_init/zswap_comp_exit/zswap_entry_cache_create is only
>> called by __init init_zswap()
>
> Thanks for the cleanup!
>
> Acked-by: Seth Jennings <sjennings@xxxxxxxxxxxxxx>

Thanks very much!

>
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@xxxxxxxxx>
>> ---
>>  mm/zswap.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/zswap.c b/mm/zswap.c
>> index 51a2c45..2e621fa 100644
>> --- a/mm/zswap.c
>> +++ b/mm/zswap.c
>> @@ -149,7 +149,7 @@ static int __init zswap_comp_init(void)
>>       return 0;
>>  }
>>
>> -static void zswap_comp_exit(void)
>> +static void __init zswap_comp_exit(void)
>>  {
>>       /* free percpu transforms */
>>       if (zswap_comp_pcpu_tfms)
>> @@ -206,7 +206,7 @@ static struct zswap_tree *zswap_trees[MAX_SWAPFILES];
>>  **********************************/
>>  static struct kmem_cache *zswap_entry_cache;
>>
>> -static int zswap_entry_cache_create(void)
>> +static int __init zswap_entry_cache_create(void)
>>  {
>>       zswap_entry_cache = KMEM_CACHE(zswap_entry, 0);
>>       return zswap_entry_cache == NULL;
>> @@ -389,7 +389,7 @@ static struct notifier_block zswap_cpu_notifier_block = {
>>       .notifier_call = zswap_cpu_notifier
>>  };
>>
>> -static int zswap_cpu_init(void)
>> +static int __init zswap_cpu_init(void)
>>  {
>>       unsigned long cpu;
>>
>> --
>> 1.7.9.5
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/