Re: [PATCH 1/2] of: Make const the device node pointers in of_clk_get and of_node_put

From: Jean-Francois Moine
Date: Sun Nov 09 2014 - 14:25:47 EST


On Sun, 9 Nov 2014 18:50:19 +0000
Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:

> What this then means is that it fundamentally undermines the idea of
> storing the pointer to a device_node as a const pointer, as the device
> node must always be modified when you're done with it (because it's a
> ref-counted structure.) So, having it const in your code is a bug.
>
> What this also means is that every other place that you've added const
> below is also very dubious.

Thanks for the explanation.

The correct patch will be simpler: in the ASoC structures, I found only
three places where the device_node pointer is const.

--
Ken ar c'hentaà | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/