RE: [PATCHv5 7/7] usb: dwc2: Update Kconfig to support dual-role

From: Paul Zimmerman
Date: Thu Oct 23 2014 - 14:28:18 EST


> From: Bartlomiej Zolnierkiewicz [mailto:b.zolnierkie@xxxxxxxxxxx]
> Sent: Wednesday, October 22, 2014 5:26 AM
>
> On Monday, October 20, 2014 01:52:06 PM dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote:
> > From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
> >
> > config USB_DWC2_PLATFORM
> > bool "DWC2 Platform"
> > - depends on USB_DWC2_HOST
> > default USB_DWC2_HOST
>
> It should be "default USB_DWC2_HOST || USB_DWC2_PERIPHERAL" because
> USB_DWC2_PLATFORM replaces current USB_DWC2_PERIPHERAL functionality.
>
> Additionaly USB_DWC2_PLATFORM should be changed to tristate
> (USB_DWC2_PERIPHERAL was a tristeate before your changes).

Dinh, I think this is a good point. Is there any reason why
USB_DWC2_PLATFORM (and USB_DWC2_PCI for that matter) can't be
tristate? That's what DWC3 does.

--
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/