Re: [PATCH 1/1] perf tool: add hists__init for perf diff

From: Arnaldo Carvalho de Melo
Date: Wed Oct 22 2014 - 15:29:48 EST


Em Wed, Oct 22, 2014 at 03:02:41PM -0400, kan.liang@xxxxxxxxx escreveu:
> From: Kan Liang <kan.liang@xxxxxxxxx>
>
> perf diff also uses hists/hist_entries, hists__init() should be called
> before creating any evsels.

Thanks, this one merits perf/urgent :-\

- Arnaldo

> Signed-off-by: Kan Liang <kan.liang@xxxxxxxxx>
> ---
> tools/perf/builtin-diff.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 8c5c11c..25114c9 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1142,6 +1142,11 @@ static int data_init(int argc, const char **argv)
>
> int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
> {
> + int ret = hists__init();
> +
> + if (ret < 0)
> + return ret;
> +
> perf_config(perf_default_config, NULL);
>
> argc = parse_options(argc, argv, options, diff_usage, 0);
> --
> 1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/