Re: [PATCH 2/5] perf, x86, uncore: Add Haswell-EP uncore support

[Alexei Starovoitov]

On Thu, Sep 4, 2014 at 4:08 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> From: "Yan, Zheng" <zheng.z.yan@xxxxxxxxx>
>
> The uncore subsystem in Haswell-EP is similar to Sandy/Ivy
> Bridge-EP. There are some differences in config register
> encoding and pci device IDs. The Haswell-EP uncore also
> supports a few new events. Add the Haswell-EP driver to
> the snbep split driver.
>
> v2: (AK): Add missing break. Add imc events. Add cbox nc/isoc/c6.
> Signed-off-by: Yan, Zheng <zheng.z.yan@xxxxxxxxx>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_uncore.c      |   7 +-
>  arch/x86/kernel/cpu/perf_event_intel_uncore.h      |   2 +
>  .../x86/kernel/cpu/perf_event_intel_uncore_snbep.c | 608 ++++++++++++++++++++-
>  3 files changed, 615 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> index 812ec5d..2b0fa02 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -883,6 +883,9 @@ static int __init uncore_pci_init(void)
>         case 62: /* Ivy Bridge-EP */
>                 ret = ivbep_uncore_pci_init();
>                 break;
> +       case 63: /* Haswell-EP */
> +               ret = hswep_uncore_pci_init();
> +               break;

my E5-1630 v3 crashes hard during boot in
snbep_uncore_msr_init_box()+0x3c
I don't have a setup to capture the screen so early in the boot.
So this is just heads up.
I replaced the call above with 'return -ENODEV' as a workaround.
btw, E5-16xx v3 became available just a month ago.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/