Re: [PATCH v5 12/20] x86: perf: intel_pt: Intel PT PMU driver

From: Peter Zijlstra
Date: Wed Oct 22 2014 - 11:14:34 EST


On Mon, Oct 13, 2014 at 04:45:40PM +0300, Alexander Shishkin wrote:
> + if ((pt_cap_get(PT_CAP_topa_multiple_entries)
> + && topa->table[i].stop)
> + || topa->table[i].end)
> + break;

> + old = (local64_xchg(&buf->head, base) &
> + ((buf->nr_pages << PAGE_SHIFT) - 1));

> + if (!pt_cap_get(PT_CAP_topa_multiple_entries) ||
> + buf->output_off == sizes(TOPA_ENTRY(buf->cur, buf->cur_idx)->size)) {
> + local_inc(&buf->lost);
> + advance++;
> + }

Inconsistent coding style. Please put operators at the end of a line,
not at the start of one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/