Re: [PATCH] drivers: net: xgene: Add missing initialization in xgene_enet_ecc_init()

From: David Miller
Date: Tue Oct 21 2014 - 21:41:35 EST


From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Mon, 20 Oct 2014 10:08:16 +0200

> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ʽxgene_enet_ecc_initʼ:
> drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ʽdataʼ may be used uninitialized in this function
>
> Depending on the arbitrary value on the stack, the loop may terminate
> too early, and cause a bogus -ENODEV failure.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Please, use a do { } while(0) loop to fix this, thanks.