Re: [PATCH v2 2/5] mfd: max77693: Map charger device to its own of_node

From: Krzysztof Kozlowski
Date: Tue Oct 21 2014 - 06:20:56 EST


On wto, 2014-10-21 at 11:17 +0100, Lee Jones wrote:
> On Mon, 20 Oct 2014, Krzysztof Kozlowski wrote:
>
> > On pon, 2014-10-20 at 16:06 +0100, Lee Jones wrote:
> > > On Mon, 20 Oct 2014, Krzysztof Kozlowski wrote:
> > >
> > > > Add a "maxim,max77693-charger" of_compatible to the mfd_cell so the MFD
> > > > child device (the charger) will have its own of_node set. This will be
> > > > used by the max77693 charger driver in next patches to obtain battery
> > > > configuration from DTS.
> > > >
> > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > > > ---
> > > > drivers/mfd/max77693.c | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> > > > index cf008f45968c..2277a11b6629 100644
> > > > --- a/drivers/mfd/max77693.c
> > > > +++ b/drivers/mfd/max77693.c
> > > > @@ -43,7 +43,10 @@
> > > >
> > > > static const struct mfd_cell max77693_devs[] = {
> > > > { .name = "max77693-pmic", },
> > > > - { .name = "max77693-charger", },
> > > > + {
> > > > + .name = "max77693-charger",
> > > > + .of_compatible = "maxim,max77693-charger",
> > > > + },
> > > > { .name = "max77693-muic", },
> > > > { .name = "max77693-haptic", },
> > > > {
> > >
> > > I'm guessing this can be applied separately?
> >
> > Yes. Patch 3/5 also (it adds necessary defines and symbols for
> > chargers).
>
> I'll take this patch, but I think 3/5 is required by some of the other
> patches in the set, no?

Yes, it is required by 4/5 (charger driver).

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/