Re: [PATCH v4 2/3] dma: imx-sdma: correct print format

From: Andy Shevchenko
Date: Tue Oct 21 2014 - 05:38:26 EST


On Tue, 2014-10-21 at 09:09 +0800, Robin Gong wrote:
> correct print format for 'size_t', 'dma_address_t',etc.

Ah, okay, you may disregard few of my comments to previous patch.

But here, please, fix the style of commit message (spaces, capital
letters, etc).

>
> Signed-off-by: Robin Gong <b38343@xxxxxxxxxxxxx>
> ---
> drivers/dma/imx-sdma.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index fc4a0df..7e8aa2d 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1041,7 +1041,7 @@ static struct dma_async_tx_descriptor *sdma_prep_memcpy(
> return NULL;
>
> if (len >= NUM_BD * SDMA_BD_MAX_CNT) {
> - dev_err(sdma->dev, "channel%d: maximum bytes exceeded:%d > %d\n"
> + dev_err(sdma->dev, "channel%d: maximum bytes exceeded:%zu > %d\n"
> , channel, len, NUM_BD * SDMA_BD_MAX_CNT);
> goto err_out;
> }
> @@ -1050,8 +1050,8 @@ static struct dma_async_tx_descriptor *sdma_prep_memcpy(
>
> sdmac->buf_tail = 0;
>
> - dev_dbg(sdma->dev, "memcpy: %x->%x, len=%d, channel=%d.\n",
> - dma_src, dma_dst, len, channel);
> + dev_dbg(sdma->dev, "memcpy: %pad->%pad, len=%zu, channel=%d.\n",
> + &dma_src, &dma_dst, len, channel);
>
> sdmac->direction = DMA_MEM_TO_MEM;
>
> @@ -1104,7 +1104,7 @@ static struct dma_async_tx_descriptor *sdma_prep_memcpy(
> param &= ~BD_CONT;
> }
>
> - dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%08x %s%s\n",
> + dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%u %s%s\n",
> i, count, bd->buffer_addr,
> param & BD_WRAP ? "wrap" : "",
> param & BD_INTR ? " intr" : "");
> @@ -1220,8 +1220,8 @@ static struct dma_async_tx_descriptor *sdma_prep_sg(
> param &= ~BD_CONT;
> }
>
> - dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%08x %s%s\n",
> - i, count, sg_src->dma_address,
> + dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%pad %s%s\n",
> + i, count, &sg_src->dma_address,
> param & BD_WRAP ? "wrap" : "",
> param & BD_INTR ? " intr" : "");
>
> @@ -1291,7 +1291,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
> }
>
> if (period_len > SDMA_BD_MAX_CNT) {
> - dev_err(sdma->dev, "SDMA channel %d: maximum period size exceeded: %d > %d\n",
> + dev_err(sdma->dev, "SDMA channel %d: maximum period size exceeded: %zu > %d\n",
> channel, period_len, SDMA_BD_MAX_CNT);
> goto err_out;
> }
> @@ -1315,8 +1315,8 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
> if (i + 1 == num_periods)
> param |= BD_WRAP;
>
> - dev_dbg(sdma->dev, "entry %d: count: %d dma: %#llx %s%s\n",
> - i, period_len, (u64)dma_addr,
> + dev_dbg(sdma->dev, "entry %d: count: %d dma: %pad %s%s\n",
> + i, period_len, &dma_addr,
> param & BD_WRAP ? "wrap" : "",
> param & BD_INTR ? " intr" : "");
>


--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/