Re: [PATCH V5] mtd: ubi: Extend UBI layer debug/messaging capabilities

From: Tanya Brokhman
Date: Tue Oct 21 2014 - 04:52:56 EST


On 10/21/2014 10:56 AM, Artem Bityutskiy wrote:
On Mon, 2014-10-20 at 19:57 +0300, Tanya Brokhman wrote:
If there is more then one UBI device mounted, there is no way to
distinguish between messages from different UBI devices.
Add device number to all ubi layer message types.

The R/O block driver messages were replaced by pr_* since
ubi_device structure is not used by it.

Signed-off-by: Tanya Brokhman <tlinder@xxxxxxxxxxxxxx>

Pushed to linux-ubifs.git, thanks.

You did not get indentations right, though, so I amended your patch.
Also, some lines were split unnecessarily. My amendments are in the diff
below. Please, take this into account for the similar UBIFS patch which
you was going to send. Thank you!

Thanks Artem and sorry for the extra work for you. I was trying to find the balance between pleasing checkpatch and your request to have the message in the same line :)
Will be extra careful about the indentation next time (guess my editor needs re-configuration). Sorry about that.


Thanks,
Tanya Brokhman
--
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/