Re: [PATCH v11 07/21] dax,ext2: Replace XIP read and write with DAX I/O

From: Matthew Wilcox
Date: Thu Oct 16 2014 - 15:51:20 EST


On Thu, Oct 16, 2014 at 11:50:27AM +0200, Mathieu Desnoyers wrote:
> > + if (rw == WRITE) {
> > + if (!buffer_mapped(bh)) {
> > + retval = -EIO;
> > + /* FIXME: fall back to buffered I/O */
>
> Fallback on buffered I/O would void guarantee about having data stored
> into persistent memory after write returns. Not sure we actually want
> that.

Yeah, I think that comment is just stale. I can't see a way in which
buffered I/O would succeed after DAX I/O falis.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/