Re: [PATCH RFC] sched: Revert delayed_put_task_struct() and fix use after free

From: Peter Zijlstra
Date: Thu Oct 16 2014 - 04:01:24 EST


On Wed, Oct 15, 2014 at 05:06:41PM +0200, Oleg Nesterov wrote:
>
> At least the code like
>
> rcu_read_lock();
> get_task_struct(foreign_rq->curr);
> rcu_read_unlock();
>
> is certainly wrong. And _probably_ the problem should be fixed here. Perhaps
> we can add try_to_get_task_struct() which does atomic_inc_not_zero() ...

There is an rcu_read_lock() around it through task_numa_compare().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/