RE: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions from common.h

From: Pankaj Dubey
Date: Tue Sep 30 2014 - 23:00:20 EST


Hi Arnd,

On Tuesday, September 30, 2014 4:09 PM, Arnd Bergmann wrote,
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: Pankaj Dubey; linux-kernel@xxxxxxxxxxxxxxx;
linux-samsung-soc@xxxxxxxxxxxxxxx;
> kgene.kim@xxxxxxxxxxx; linux@xxxxxxxxxxxxxxxx; naushad@xxxxxxxxxxx;
> tomasz.figa@xxxxxxxxx; thomas.ab@xxxxxxxxxxx; vikas.sajjan@xxxxxxxxxxx
> Subject: Re: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions
from
> common.h
>
> On Tuesday 30 September 2014 15:51:21 Pankaj Dubey wrote:
> >
> > +static inline void pmu_raw_writel(u32 val, u32 offset) {
> > + __raw_writel(val, pmu_base_addr + offset); }
> > +
> > +static inline u32 pmu_raw_readl(u32 offset) {
> > + return __raw_readl(pmu_base_addr + offset); }
> > +
> >
>
> While you're at it, please convert these to use readl_relaxed() instead,
which is safe to
> use in drivers and works independent of CPU endianess.
>

OK, I will update this.

Thanks,
Pankaj Dubey
> Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/