RE: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit

From: Opensource [James Seong-Won Ban]
Date: Tue Sep 30 2014 - 21:02:36 EST


On Tuesday, September 30, 2014 9:45 PM Mark Brown wrote:

> From: Mark Brown [mailto:broonie@xxxxxxxxxx]
> Sent: Tuesday, September 30, 2014 9:45 PM
> To: Opensource [James Seong-Won Ban]
> Cc: Liam Girdwood; Support Opensource; LKML; David Dajun Chen
> Subject: Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
>
> On Mon, Sep 29, 2014 at 04:59:20PM +0900, James Ban wrote:
> > This is a patch for fixing a bug about mask bit operation.
>
> Applied, but please try to make sure that your changelogs are more
> descriptive - what is the bug? Please also use subject lines matching
> the style for the subsystem.
The proper operation of mask bit should be set as '0' for enabling the interrupt.
The result of mask operation at previous code was the same to new one.
But the meaning in the previous code was to set mask bit as '1'.
What is subject line you said?
If you give me an example, it would be very helpful to me.

Regards,
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/