Re: [PATCH v4] hwspinlock: qcom: Add support for Qualcomm HW Mutex block

[Bjorn Andersson]

On Tue 30 Sep 15:14 PDT 2014, Jeffrey Hugo wrote:

> On 9/29/2014 10:35 PM, Bjorn Andersson wrote:

[..]

> > +static int qcom_hwspinlock_probe(struct platform_device *pdev)
> > +{
> > +	struct device_node *node = pdev->dev.of_node;
> > +	const struct of_device_id *match;
> > +	struct hwspinlock_device *bank;
> > +	struct hwspinlock *hwlock;
> > +	struct resource *res;
> > +	void __iomem *iobase;
> > +	unsigned stride, i;
> > +	size_t array_size;
> > +	u32 num_locks;
> > +	int ret;
> > +
> > +	match = of_match_device(qcom_hwspinlock_of_match, &pdev->dev);
> Didn't this have error handling in v2?

It did, but as this is a platform_device and we only support DTthere is no way
match will be NULL if we end up here. So the possible check would be to see
that data is non-null, but for this driver that wouldn't make sense.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/