Re: [tpmdd-devel] [PATCH v1 12/12] tpm: TPM2 sysfs attributes

From: Jarkko Sakkinen
Date: Tue Sep 30 2014 - 16:07:43 EST


On Fri, Sep 26, 2014 at 08:19:47PM +0300, Jarkko Sakkinen wrote:
> On Wed, Sep 24, 2014 at 02:46:27PM -0600, Jason Gunthorpe wrote:
> > > That would be 24*2 files only for pcrs...
> >
> > Some subsystems do just that..
> >
> > $ ls /sys/class/infiniband/qib0/ports/1/sl2vl/
> > 0 1 10 11 12 13 14 15 2 3 4 5 6 7 8 9
>
> They use static structures in drivers/infiniband/hw/qib/qib_sysfs.c
> and it does not looks a mess. I would prefer to create struct attribute
> entries dynamically if there's clean and easy way to do that.

I gave this a shot:

https://github.com/jsakkine/linux-tpm2/commit/dffce68ce34da265a62908dec71b2d85fc16824f

I want to initialize dynamically so that it is easy to support
TPM_PT_PCR_COUNT later.

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/