Re: [PATCH] gpiolib: fix callers of gpiochip_remove

From: Linus Walleij
Date: Tue Sep 30 2014 - 10:11:35 EST


On Tue, Sep 30, 2014 at 3:24 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> A recent API change made gpiochip_remove return void instead of an
> error value, which broke drivers that use this return value:
>
> gpio/gpio-sch311x.c: In function 'sch311x_gpio_probe':
> gpio/gpio-sch311x.c:286:7: error: void value not ignored as it ought to be
> if (gpiochip_remove(&priv->blocks[i].chip))
> ^
>
> This changes the callers that I have found during randconfig testing
> so they no longer depend on the error code.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: e1db1706c86e ("gpio: gpiolib: set gpiochip_remove retval to void")

Hm AFAICT these are already fixes in my GPIO tree
and linux-next...

Am I looking in the wrong place?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/