Re: [RESEND v3 PATCH 3/3] vfs: make mounts and mountstats honor root dir like mountinfo does

[Dmitry V. Levin]

On Mon, Sep 29, 2014 at 08:33:29PM +0100, Al Viro wrote:
> On Mon, Sep 29, 2014 at 10:43:33PM +0400, Dmitry V. Levin wrote:
> > On Mon, Sep 29, 2014 at 07:32:22PM +0100, Al Viro wrote:
> > > On Mon, Sep 29, 2014 at 10:05:23PM +0400, Dmitry V. Levin wrote:
> > > > Date: Wed, 17 Oct 2012 20:29:55 +0400
> > > > 
> > > > Change show_vfsmnt() and show_vfsstat() to show mountpoints relative
> > > > to the root directory and skip mountpoints outside of chroot jail
> > > > the same way as show_mountinfo() does.
> > > 
> > > Sigh...  Repeat after me:  We  Do  Not  Break  Userland.  Care to explain
> > > why that change won't do just that?
> > 
> > This is definitely an information leak, and I cannot imagine how these
> > unaccessible entries listed in /proc/self/mounts and /proc/self/mountstats
> > could be used sanely.
> 
> How do you think any existing script running chrooted is going to parse
> /proc/mounts?  One obvious way is to filter on known prefix and strip it
> away.  With your change it will instantly break.  Moreover, any script
> working with *new* semantics will break as soon as you boot an older
> kernel.

If a script relies on this behaviour, it is likely to be broken already
because the kernel strips chroot prefix somehow (I've just checked back to
2.6.32).  The main purpose of this patch is to exclude from listing those
mount points that do not belong to the chroot at all.

> Existing behaviour had been there since mid-90s (at least) and I'm absolutely
> certain that such scripts do exist.  I know that, since I had to write such.

I'm very curious, what could your scripts do with paths outside chroot,
assuming that prefix removal was done by the kernel?

> Again, we do not break userland.

Occasionally, we do.  If you say there was no chroot prefix removal in the
kernel before, and there seems to be a prefix removal for at least 5 years,
then there must have been a break some years ago that went unnoticed.


-- 
ldv
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/