Re: [PATCH v1 2/5] driver-core: enable drivers to opt-out of async probe

[Luis R. Rodriguez]

On Sun, Sep 28, 2014 at 10:33:24AM -0400, Tejun Heo wrote:
> On Fri, Sep 26, 2014 at 02:57:14PM -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > 
> > We'll soon add generic support for asynchronous probe, before
> > that gets merged lets let drivers annotate if they should never
> > probe asynchronously.
> > 
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Cc: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Doug Thompson <dougthompson@xxxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> > Cc: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> > Cc: linux-edac@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
> > ---
> >  include/linux/device.h | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/include/linux/device.h b/include/linux/device.h
> > index 43d183a..4de6328 100644
> > --- a/include/linux/device.h
> > +++ b/include/linux/device.h
> > @@ -200,6 +200,10 @@ extern struct klist *bus_get_device_klist(struct bus_type *bus);
> >   * @owner:	The module owner.
> >   * @mod_name:	Used for built-in modules.
> >   * @suppress_bind_attrs: Disables bind/unbind via sysfs.
> > + * @sync_probe: requests probe to be run always be run synchronously even
> 
> "be run" repeated in the sentence.
> 
> > + * 	if userspace asked us to run asynchronously. Some devices drivers
> > + * 	may be known to not work well with async probe, use this to annotate
> > + * 	your driver if you know it needs synchronous probe.
> 
> Maybe something like "Use this to annotate drivers which don't work
> well with async probe." is better?

Sure.

> The formatting seems inconsistent with other comments.

Fixed.

  LUis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/