Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

From: Wolfram Sang
Date: Mon Sep 29 2014 - 08:51:11 EST


> >>Its looks good if we move the entire ISR above probe/remove
> >>functionalities...
> >>
> >Not sure what you mean here... The ISR _is_ above probe/remove.
>
> I mean ISR should immediately above probe functionality. So that we can see
> devm_request_irq(..,isr_name,..) ISR directly with isr name..

Not so important to me, '*' in vim does that whereever the function is.

Still, thanks for the review!

Attachment: signature.asc
Description: Digital signature