Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities

[Kiran Padwal]

On Monday 29 September 2014 05:31 PM, Richard Weinberger wrote:
> Am 29.09.2014 12:50, schrieb Kiran Padwal:
>> Hi Tanya,
>>
>> On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote:
>>> If there is more then one UBI device mounted, there is no way to
>>> distinguish between messages from different UBI devices.
>>> Add device number to all ubi layer message types.
>>>
>>>
>>> Signed-off-by: Tanya Brokhman <tlinder@xxxxxxxxxxxxxx>
>>>
>>> ---
>>>  drivers/mtd/ubi/attach.c  | 138 ++++++++++++++++++++----------------
>>>  drivers/mtd/ubi/build.c   | 130 ++++++++++++++++++++--------------
>>>  drivers/mtd/ubi/cdev.c    |  37 +++++-----
>>>  drivers/mtd/ubi/debug.c   |   9 +--
>>>  drivers/mtd/ubi/eba.c     |  54 +++++++-------
>>>  drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------
>>>  drivers/mtd/ubi/io.c      | 177 +++++++++++++++++++++++++++-------------------
>>>  drivers/mtd/ubi/kapi.c    |   6 +-
>>>  drivers/mtd/ubi/misc.c    |   6 +-
>>>  drivers/mtd/ubi/ubi.h     |  13 ++--
>>>  drivers/mtd/ubi/vmt.c     |  76 +++++++++++---------
>>>  drivers/mtd/ubi/vtbl.c    |  54 ++++++++------
>>>  drivers/mtd/ubi/wl.c      |  87 +++++++++++++++--------
>>>  13 files changed, 521 insertions(+), 374 deletions(-)
>>
>> Compilation breaks while I try to compile with this patch.
>> May be you need to update remaining ubi layer messages also.
> 
> Please always share the errors you face.
> Maybe you have a different config.

Sure, I will take care of this next time.

Macros have been changed but some instances of older macros still remained, which caused many errors like,

drivers/mtd/ubi/build.c: In function ‘ubi_init’:
drivers/mtd/ubi/build.c:1322:49: error: expected ‘)’ before ‘err’
   ubi_err("block: cannot initialize, error %d", err);
                                                 ^

> 
> Thanks,
> //richard
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/