Re: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases

From: Masami Hiramatsu
Date: Mon Sep 29 2014 - 06:33:33 EST


(2014/09/26 23:18), Steven Rostedt wrote:
> On Fri, 26 Sep 2014 21:04:26 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
>
>
>>> Please go ahead and get them in. The framework might have to wait
>>> until 3.19, so there is no need to have it gate test development.
>>> We can evolve them as we go. If tests require special, it means that
>>> they aren't suitable for certain envs such as qemu boot with busybox.
>>> There is a plan to add test targets to cover such cases.
>>
>> Agreed, anyway, in some env those tools(commands) may not supported
>> by busybox because of the memory size etc. In that case, we can just
>> mark the test unsupported or xfail.
>>
>
> Note, if memory size is such a big issue it that other tools may not be
> there, then most of the ftrace features will probably be disabled due
> to memory constraints on the kernel itself.

Agreed :)

>
> As we have a way to state "unsupported" we can just return that from
> tests that require tools not available, and say why it is the case.

OK, if we can count "unsupported" as a test failure (yes, it is
unexpectedly failed), it is easy to fix. I'll update XFAIL and
other error code support patch and send it.

Thank you,

--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/