Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

[Varka Bhadram]

On 09/29/2014 03:43 PM, Wolfram Sang wrote:
> > > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > Error checking on *res*...?
> >
> > We should *return* on platform_get_resource() failure..
> >
> > > +	base = devm_ioremap_resource(&pdev->dev, res);
> Nope. devm_ioremap_resource does that.
Yes it will [1]. Thanks for the clarification.

[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117

--
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/