Re: [PATCH] description and restrictions of _shipped

From: Joe Perches
Date: Sun Sep 28 2014 - 14:16:30 EST


On Sun, 2014-09-28 at 19:55 +0200, Nicholas Mc Guire wrote:
> This patch adds a section on handling of _shipped files
> and their limitations.

Good idea but:

> While it is not actually the right place to rant about binary
> modules, it probably would also be bad not to clearly state that
> this option is not preferred.
[]
> diff --git a/Documentation/kbuild/makefiles.txt b/Documentation/kbuild/makefiles.txt
[]
> @@ -19,6 +19,7 @@ This document describes the Linux kernel Makefiles.
> --- 3.10 Special Rules
> --- 3.11 $(CC) support functions
> --- 3.12 $(LD) support functions
> + --- 3.13 _shipped binary blobs

*_shipped files are not just binary.

Perhaps these are better described as "auto-generated" files.

The _shipped files in drivers/scsi/aic7xxx/ should probably
just be renamed.

$ git ls-files -- "*_shipped"
arch/arm/crypto/aesbs-core.S_shipped
arch/powerpc/platforms/cell/spufs/spu_restore_dump.h_shipped
arch/powerpc/platforms/cell/spufs/spu_save_dump.h_shipped
drivers/net/wan/wanxlfw.inc_shipped
drivers/scsi/53c700_d.h_shipped
drivers/scsi/aic7xxx/aic79xx_reg.h_shipped
drivers/scsi/aic7xxx/aic79xx_reg_print.c_shipped
drivers/scsi/aic7xxx/aic79xx_seq.h_shipped
drivers/scsi/aic7xxx/aic7xxx_reg.h_shipped
drivers/scsi/aic7xxx/aic7xxx_reg_print.c_shipped
drivers/scsi/aic7xxx/aic7xxx_seq.h_shipped
drivers/tty/vt/defkeymap.c_shipped
scripts/dtc/dtc-lexer.lex.c_shipped
scripts/dtc/dtc-parser.tab.c_shipped
scripts/dtc/dtc-parser.tab.h_shipped
scripts/genksyms/keywords.hash.c_shipped
scripts/genksyms/lex.lex.c_shipped
scripts/genksyms/parse.tab.c_shipped
scripts/genksyms/parse.tab.h_shipped
scripts/kconfig/zconf.hash.c_shipped
scripts/kconfig/zconf.lex.c_shipped
scripts/kconfig/zconf.tab.c_shipped


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/