Re: [PATCH] unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP

From: Xuetao Guan
Date: Sat Sep 27 2014 - 21:49:55 EST


Sorry for late reply.

I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig
Sure, removing it means no different for .config file.
I think a better way is reserving it or moving it into arch/Kconfig

Cc: linux-arch@xxxxxxxxxxxxxxx

Xuetao Guan

----- Paul Bolle <pebolle@xxxxxxxxxx> åéï
> Architectures only need a Kconfig entry for NO_IOPORT_MAP if it is
> possible that its value will be 'y'. For unicore32 its value will always
> be 'n', making it pointless. Remove it.
>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> Tested by playing with arch/unicore32/configs/unicore32_defconfig. This
> patch made no difference whatsoever to the generated .config file.
> Please note that it has
> CONFIG_HAS_IOPORT_MAP=y
>
> set after invoking "make oldconfig" both before and after this patch.
>
> arch/unicore32/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index 928237a7b9ca..2322cc87e7cb 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -27,9 +27,6 @@ config UNICORE32
> config GENERIC_CSUM
> def_bool y
>
> -config NO_IOPORT_MAP
> - bool
> -
> config STACKTRACE_SUPPORT
> def_bool y
>
> --
> 1.9.3
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/