Re: [GIT PULL] at91: soc for 3.18 #2

From: Arnd Bergmann
Date: Fri Sep 26 2014 - 06:50:58 EST


On Monday 22 September 2014, Nicolas Ferre wrote:

> Nicolas Ferre (4):
> ARM: at91: introduce basic SAMA5D4 support
> ARM: at91: SAMA5D4 SoC detection code and low level routines

This resulted in build failures both in at91x40_defconfig and some
randconfigs with MMU disabled. I've applied the patch below on top
to fix it.

I'm not exactly happy about the soc detection code anyway after I
had to look at that. Why do you even hardcode the physical register
location rather than getting it from DT?

Also, why do you care about which SoC version you have for the
modern SAMA5 chips? All I see is a sama5d4_map_io() callback
that maps a lot of completely unused registers along with
the uart that you normally get from the implicit debug_ll_io_init,
and the SRAM that should probably be turned into a normal driver.

Arnd
8<-------