RE: [PATCH] kobject: fix NULL pointer derefernce in kobj_child_ns_ops

From: Pankaj Dubey
Date: Thu Sep 25 2014 - 23:22:42 EST


Hi Greg,

On Thursday, September 25, 2014 4:15 PM, Greg KH wrote,
> To: Pankaj Dubey
> Cc: linux-kernel@xxxxxxxxxxxxxxx; naushad@xxxxxxxxxxx
> Subject: Re: [PATCH] kobject: fix NULL pointer derefernce in
kobj_child_ns_ops
>
> On Wed, Sep 24, 2014 at 04:25:54PM +0530, Pankaj Dubey wrote:
> > We will hit NULL pointer dereference if we call
> > platform_device_register_simple or platform_device_add at very early
> > stage. I have observed following crash when called platform_device_add
> > from "init_irq" hook of machine_desc. This patch fixes this issue and
> > let system handle this case gracefully instead of kernel panic.
>
> Is there any in-tree code that needs this "fix"? Or can it wait for 3.18?
>

Even though I am not completely sure, at least I could not see any in-tree
code
which may need this fix.
I posted this fix, because while working on one of syscon patch [1] I wanted
to call
"platform_device_add" in one of APIs which may get called during very early
stage
of system boot, and during that time it will lead to kernel panic.

But mine syscon related patch is still under review, so I think this patch
can wait
for 3.18.

[1]: https://lkml.org/lkml/2014/9/22/12

Thanks,
Pankaj Dubey


> thanks,
>
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/