Re: [PATCH] i2c: move acpi code back into the core

From: Wolfram Sang
Date: Wed Sep 24 2014 - 11:43:53 EST


> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 809ecd680d88..e3682d0dea1e 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4477,7 +4477,6 @@ M: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> > L: linux-i2c@xxxxxxxxxxxxxxx
> > L: linux-acpi@xxxxxxxxxxxxxxx
> > S: Maintained
> > -F: drivers/i2c/i2c-acpi.c
>
> You can remove my name from MAINTANERS as well. I'm not I2C subsystem
> maintainer :) Of course I will still assist reviewing ACPI related
> changes in i2c-core.c.

I'd like to keep this since the header says I2C/ACPI. I am thinking of
adding something like 'K: i2c_.*acpi_' but that can wait. For now, we
need a working solution _very_ soon.

> > +#endif
>
> I would put there
>
> #endif /* CONFIG_ACPI_I2C_OPREGION */

I didn't want to change lines not written by me, but well yeah...

> Also please remove all ACPI related stuff in include/linux/i2c.h. That
> is not needed anymore.

Yup, thanks!

Attachment: signature.asc
Description: Digital signature