Re: [PATCH] kvm-vfio: do not use module_init

[Will Deacon]

On Wed, Sep 24, 2014 at 12:29:09PM +0100, Paolo Bonzini wrote:
> /me got confused between the kernel and QEMU.  In the kernel, you can
> only have one module_init function, and it will prevent unloading the
> module unless you also have the corresponding module_exit function.

Happy for you to take the blame, but I think this one's my fault!

> So, commit 80ce1639727e (KVM: VFIO: register kvm_device_ops dynamically,
> 2014-09-02) broke unloading of the kvm module, by adding a module_init
> function and no module_exit.

I forget kvm builds as a module for other architectures (ie. not arm/arm64).

> Repair it by making kvm_vfio_ops_init weak, and checking it in
> kvm_init.

Hehe, if only there was a kconfig option for kvm-vfio.c...

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/