RE: [PATCH] ata: Disabling the async PM for JMicron chips

From: Liu, Chuansheng
Date: Wed Sep 24 2014 - 02:30:09 EST




> -----Original Message-----
> From: Tejun Heo [mailto:htejun@xxxxxxxxx] On Behalf Of Tejun Heo
> Sent: Tuesday, September 23, 2014 10:01 PM
> To: Liu, Chuansheng
> Cc: rjw@xxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; mister.freeman@xxxxxxxxxxx; Zhang, Rui
> Subject: Re: [PATCH] ata: Disabling the async PM for JMicron chips
>
> On Tue, Sep 23, 2014 at 01:37:51PM +0800, Chuansheng Liu wrote:
> > Be similar with commit (ata: Disabling the async PM for JMicron chip
> 363/361),
>
> Please use 12_DIGIT_SHA1_PREFIX ("SUBJ") format when referring to
> commits.
>


> > @@ -1345,10 +1345,10 @@ static int ahci_init_one(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> > * follow the sequence one by one, otherwise one of them can not be
> > * powered on successfully, so here we disable the async suspend
> > * method for these chips.
> > + * Jmicron chip 368 has been found has the similar issue, here we can
> > + * exclude the Jmicron family directly to avoid other similar issues.
>
> Let's update the comment as a whole instead of appending to it.
>

Thanks your comments, Tejun, will send one new patch to review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/