Re: [PATCH V3 RESEND] SYSV: logging update

[Fabian Frederick]

> On 20 September 2014 at 01:00 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>
> On Sat, 13 Sep 2014 23:12:36 +0200 Fabian Frederick <fabf@xxxxxxxxx> wrote:
>
> > -use current logging functions
> > -replace no level printk by pr_err
> > -add debug.c / sysv_err function to include sb->s_id
> > -use pr_fmt with standard KBUILD_MODNAME ": "
> > -use __builtin_return_address to display function name
> > logging format is now:
> > sysv: (sb->s_id) sysv_fill_super [sysv]: msg
>
> Is this patch tested?

Yes but looking at it again I wonder if __builtin_return_address is the best
function to use. %pf displays "sysv_fill_super [sysv]".
Maybe a trivial question but is there a way to have it simply display function
name ?

Of course I hope to have more feedback/testing to improve this patch.

Regards,
Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/