RE: [PATCH 1/4 v4] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver

[Chen, Alvin]

> > +		if (pp->idx == 0 &&
> > +		    of_property_read_bool(port_np, "interrupt-controller")) {
> > +			pp->irq = irq_of_parse_and_map(port_np, 0);
> > +			if (!pp->irq) {
> > +				dev_warn(dev, "no irq for bank %s\n",
> > +					 port_np->full_name);
> > +			}
> > +		} else {
> > +			pp->irq	= 0;
> > +		}
> 
> The else clause is not needed since pp->irq == 0 already, right?
> 
Yes, while call kcalloc, the memory is set to '0'. I will improve it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/