RE: [PATCH v8 09/10] x86, mpx: cleanup unused bound tables

From: Ren, Qiaowei
Date: Thu Sep 11 2014 - 23:02:48 EST




On 2014-09-11, Hansen, Dave wrote:
> On 09/11/2014 01:46 AM, Qiaowei Ren wrote:
>> + * This function will be called by do_munmap(), and the VMAs
>> + covering
>> + * the virtual address region start...end have already been split
>> + if
>> + * necessary and remvoed from the VMA list.
>
> "remvoed" -> "removed"
>
>> +void mpx_unmap(struct mm_struct *mm,
>> + unsigned long start, unsigned long end) {
>> + int ret;
>> +
>> + ret = mpx_try_unmap(mm, start, end);
>> + if (ret == -EINVAL)
>> + force_sig(SIGSEGV, current);
>> +}
>
> In the case of a fault during an unmap, this just ignores the
> situation and returns silently. Where is the code to retry the
> freeing operation outside of mmap_sem?

Dave, you mean delayed_work code? According to our discussion, it will be deferred to another mainline post.

Thanks,
Qiaowei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/