Re: [PATCH] staging: lustre: lov_pack: fix coding style issue

From: Joe Perches
Date: Mon Sep 01 2014 - 12:26:28 EST


On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote:
> Fix the style error checking by checkpatch.pl
> ERROR: space required after that ','
[]
> diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
[]
> @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
> void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
> {
> lov_dump_lmm_common(level, lmm);
> - CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
> + CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);

I think it better to separate the pre-coalesced
bits of the string like:

"pool name " LOV_POOLNAMEF "\n",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/