Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

From: Chase Southwood
Date: Sun Aug 31 2014 - 15:09:54 EST


On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott <abbotti@xxxxxxxxx> wrote:
>
> That seems fine. Perhaps the variable 'p' in usbdux_ao_insn_write() should
> also be of type '__le16 *'?
>

You're entirely correct. I had seen this in the output from Sparse,
but for some reason at first glance I had convinced myself that the
fix would be more complicated than it is. I'll get a patch out with a
Suggested-by: tag for you very soon.

Thanks,
Chase

> Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
>
> --
> -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
> -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/