Re: ååï Re: [PATCH] unicore32: Fix build error

From: Guenter Roeck
Date: Fri Aug 15 2014 - 22:22:03 EST


On 08/15/2014 05:45 PM, Xuetao Guan wrote:

----- Guenter Roeck <linux@xxxxxxxxxxxx> åéï
On 08/10/2014 08:29 AM, Guenter Roeck wrote:
unicore32 builds fail with

arch/unicore32/kernel/signal.c: In function âsetup_frameâ:
arch/unicore32/kernel/signal.c:257: error:
âusigâ undeclared (first use in this function)
arch/unicore32/kernel/signal.c:279: error:
âusigâ undeclared (first use in this function)
arch/unicore32/kernel/signal.c: In function âhandle_signalâ:
arch/unicore32/kernel/signal.c:306: warning: unused variable âtskâ
arch/unicore32/kernel/signal.c: In function âdo_signalâ:
arch/unicore32/kernel/signal.c:376: error:
implicit declaration of function âget_signslâ
make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
make: *** [arch/unicore32/kernel/signal.o] Error 2

Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
signal_setup_done()").

This code never even compiled. Reverting the patch does not work,
since previously used functions no longer exist, so try to fix it up.
Compile tested only.

Cc: Richard Weinberger <richard@xxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

ping ...

Failure is still present in upstream kernel (v3.16-11383-gc9d2642).

Guenter


Thanks. I'll fix it.


More a question of applying (and if possible testing) the patch I provided.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/