Re: [PATCH v2] zram: fix incorrectly stat with failed_reads

From: Minchan Kim
Date: Wed Aug 13 2014 - 20:26:49 EST


On Wed, Aug 13, 2014 at 10:01:45AM +0800, Chao Yu wrote:
> Since we allocate a temporary buffer in zram_bvec_read to handle partial page
> operations in this commit 924bd88d703e53d30f393fac6117f8f1bc79aab6 (Staging:
> zram: allow partial page operations), our ->failed_reads value may be incorrect
> as we do not increase its value when failed to allocate the temporary buffer.
>
> Let's fix this issue and correct the annotation of failed_reads.
>
> v2: clean codes of failed_{reads,writes} stat pointed out by Minchan Kim, and
> this cleanup also fix incorrectly stat when fail in zram_decompress_page.
>
> Signed-off-by: Chao Yu <chao2.yu@xxxxxxxxxxx>

Acked-by: Minchan Kim <minchan@xxxxxxxxxx>

Thanks!

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/