Re: [PATCH v2 1/3] ARM: EXYNOS: Fix build with PM_SLEEP=n and ARM_EXYNOS_CPUIDLE=n

[Bartlomiej Zolnierkiewicz]

Hi,

On Tuesday, August 12, 2014 10:49:12 PM Daniel Lezcano wrote:
> On 08/12/2014 05:11 PM, Bartlomiej Zolnierkiewicz wrote:
> > Fix building of exynos_defconfig with disabled CONFIG_PM_SLEEP by
> > adding checking whether Exynos cpuidle support is enabled before
> > accessing exynos_enter_aftr.
> >
> > The build error message:
> > arch/arm/mach-exynos/built-in.o:(.data+0x74): undefined reference to `exynos_enter_aftr'
> > make: *** [vmlinux] Error 1
>  >
> > This patch has been tested on Exynos4210 based Origen board.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > ---
> >   arch/arm/mach-exynos/exynos.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> > index 6a24e11..d57f136 100644
> > --- a/arch/arm/mach-exynos/exynos.c
> > +++ b/arch/arm/mach-exynos/exynos.c
> > @@ -161,7 +161,9 @@ static void exynos_restart(enum reboot_mode mode, const char *cmd)
> >
> >   static struct platform_device exynos_cpuidle = {
> >   	.name              = "exynos_cpuidle",
> > +#ifdef CONFIG_ARM_EXYNOS_CPUIDLE
> >   	.dev.platform_data = exynos_enter_aftr,
> > +#endif
> >   	.id                = -1,
> >   };
> 
> This patch does not address the real issue of the compilation error. The 
> cpuidle driver needs the exynos_enter_aftr function in order to work 
> correctly. Hence the Makefile should be fixed in order to compile pm.o 
> if cpuidle or pm_sleep are set.

Please take a look at patch #3.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/