Re: [PATCH 0/3] fs/proc/task_nommu.c: copy-and-paste the changes from task_mmu.c

From: Greg Ungerer
Date: Tue Aug 12 2014 - 10:09:31 EST


Hi Oleg,

On 12/08/14 03:00, Oleg Nesterov wrote:
Greg, could you review? The changes are simple, but I am not familiar
with NOMMU and I can't test this.

Depends on

[PATCH v2 3/7] proc: introduce proc_mem_open()
http://marc.info/?l=linux-kernel&m=140726831328943

[PATCH v2 4/7] fs/proc/task_mmu.c: shift mm_access() from m_start() to proc_maps_open()
http://marc.info/?l=linux-kernel&m=140726828328929
(only because it adds proc_maps_private->mm)

I'll also send you mbox with the previous series just in case.

Oleg.

fs/proc/task_nommu.c | 65 ++++++++++++++++++++++++++++++--------------------
1 files changed, 39 insertions(+), 26 deletions(-)

I don't see any problems. Applied cleanly for me (to a 3.16-rc7 tree), compiled
cleanly for a non-mmu m68k target, and ran with no problems I could see.
At least I checked /proc/1/maps and that still came out fine. Is there anything
else I should check?

I am happy to ack it:

Acked-by: Greg Ungerer <gerg@xxxxxxxxxxx>

Regards
Greg



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/