Re: [PATCH] xen_hvc: no reason to write the type key on xenstore

From: Stefano Stabellini
Date: Mon Aug 11 2014 - 10:34:12 EST


CC'ing tty maintainers.

On Mon, 11 Aug 2014, Stefano Stabellini wrote:
> The backend type is chosen by the toolstack. Regardless, the frontend
> should not care, especially given that it cannot have an effect as the
> backend is started before this code is run.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>
> diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
> index 636c9ba..b8491f5 100644
> --- a/drivers/tty/hvc/hvc_xen.c
> +++ b/drivers/tty/hvc/hvc_xen.c
> @@ -402,9 +402,6 @@ static int xencons_connect_backend(struct xenbus_device *dev,
> evtchn);
> if (ret)
> goto error_xenbus;
> - ret = xenbus_printf(xbt, dev->nodename, "type", "ioemu");
> - if (ret)
> - goto error_xenbus;
> ret = xenbus_transaction_end(xbt, 0);
> if (ret) {
> if (ret == -EAGAIN)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/