Re: [RFC PATCH] Flipped jump labels

From: Ingo Molnar
Date: Sun Aug 10 2014 - 11:45:25 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Sun, Aug 10, 2014 at 08:13:03AM +0200, Ingo Molnar wrote:
> > Wouldn't using STATIC_KEY_INIT_TRUE and static_key_true() [instead of
> > !static_key_false()] result in the same good code placement effects?
>
> Nope, not really. static_key_true() is !static_key_false() and we're not
> changing anything, logically. ASM looks non-optimal here, in any case,
> with the "true" version.

Indeed - but could we use that interface to cleanly expose the
arch_static_branch_active() code you've written, or do we need new
variants?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/