Re: [PATCH linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling' warning

From: David Rientjes
Date: Fri Aug 08 2014 - 18:03:48 EST


On Fri, 8 Aug 2014, Jeremiah Mahler wrote:

> A sparse warning is generated about 'tlb_single_page_flush_ceiling'
> not being declared.
>
> arch/x86/mm/tlb.c:177:15: warning: symbol
> 'tlb_single_page_flush_ceiling' was not declared. Should it be static?
>
> Since it isn't used anywhere outside this file, fix the warning by
> making it static.
>
> Signed-off-by: Jeremiah Mahler <jmmahler@xxxxxxxxx>

Seems like __read_mostly would also be in order?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/