Re: [PATCH 5/5] Export the temperatures via hwmon

From: Goffredo Baroncelli
Date: Thu Aug 07 2014 - 15:22:14 EST


On 08/07/2014 08:16 PM, Guenter Roeck wrote:
> On Thu, Aug 07, 2014 at 07:50:00PM +0200, Goffredo Baroncelli wrote:

>> When (if) these patches will be accepted I want to write another solution,
>> but definitely not now. And even if it would work for me, it is very likely
>> that will be accepted because nobody is able to test it on all hardware.
>>
> Might have been easier to just drop all this non-standard code and instantiate
> the adm1030 using the adm1031 driver instead.

I really like the idea, and this is a possible future work; but now we can't.

We have to suppose that the current driver work (they stopped to work because
it was changed the i2c api) and because I can't test a change on
all the apple hardware (powermac, apple laptop...), I am allowed to make only
very small changes.

My (our) first goal is to bring to life *this* driver.

I repeat I am fully convinced that re-using the "official" i2c drive/client
is the "right thing to do" (tm). But due to the lacking of the hardware where it
is possible to test this module, we need to be very conservative.

>
> Guenter
>
Goffredo


--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/