Re: sel_netif_init: 'err' is used uninitialized (was: Re: selinux: reduce the number of calls to synchronize_net() when flushing caches)

From: Paul Moore
Date: Thu Aug 07 2014 - 10:26:35 EST


On Thursday, August 07, 2014 12:31:15 PM Geert Uytterhoeven wrote:
>
> security/selinux/netif.c: In function âsel_netif_initâ:
> /scratch/geert/linux/linux-m68k/security/selinux/netif.c:285: warning:
> âerrâ is used uninitialized in this function
>
> Should it just return 0, like before?
> Or should it return the return value of register_netdevice_notifier()
> instead, which also returns an error code? Or is that failure non-critical?

Hi,

I posted a fix for this two days ago to the SELinux list (see below). As soon
as -rc1 is released and linux-next is back in business I'll be pushing the
patch to the SELinux #next branch.

* http://marc.info/?l=selinux&m=140727033030054&w=2

--
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/