RE: [PATCH 3/4] mfd: imanager2: Add Core supports for IT8516/18/28

From: Wei-Chun Pan
Date: Thu Aug 07 2014 - 05:48:25 EST


I have a question for your comment. As your mail,

> > +
> > +static void __exit imanager2_mfd_device_exit(void) {
> > + mfd_remove_devices(&ec_pdev->dev);
> > + platform_device_unregister(ec_pdev);
> > +}
> > +
> > +module_init(imanager2_mfd_device_init);
> > +module_exit(imanager2_mfd_device_exit);
>
> This is a mess. Use module_platform_driver() instead.
>
> > +MODULE_AUTHOR("Richard Vidal-Dorsch <richard.dorsch at
> > +advantech.com>");
> > +MODULE_DESCRIPTION("iManager2 platform device definitions v"
> > +DRV_VERSION); MODULE_LICENSE("GPL"); MODULE_VERSION(DRV_VERSION);
>

How can I use module_platform_driver() and my driver exit function also can do
mfd_remove_devices().
Or any other better function install of mfd_remove_devices()?

Signed-off-by: Wei-Chun Pan <weichun.pan@xxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/