Re: [PATCH] rtl8150: Check if RSR is already defined

[David Miller]

From: Nick Krause <xerofoiify@xxxxxxxxx>
Date: Thu,  7 Aug 2014 07:24:54 +0200

> I am getting the following warn
> 
> drivers/net/usb/rtl8150.c:30:0: warning: "RSR" redefined
> arch/xtensa/include/asm/processor.h:189:0: note: this is the location of the previous definition
> 
> I wanted to remove RSR as it is not being used but it is not clear if being used
> for documenting purpose. undefining should be enough.
> 
> Signed-off-by: Nick Krause <xerofoify@xxxxxxxxx>

This isn't the right way to fix this.

Rather, the thing to do is to give the macros in this driver an
appropriate prefix such as "RTL8150_" so that they don't collide
with things in the global namespace.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/